Skip to content

DTR-4472 Feat: Screen VH-02a/b/c Verification request submitted#153

Open
abhinavgupta-hmrc wants to merge 39 commits intomainfrom
DTR-4472
Open

DTR-4472 Feat: Screen VH-02a/b/c Verification request submitted#153
abhinavgupta-hmrc wants to merge 39 commits intomainfrom
DTR-4472

Conversation

@abhinavgupta-hmrc
Copy link
Copy Markdown
Contributor

Feat: CIS VSF: Screen VH-02a/b/c Verification request submitted

@platops-pr-bot
Copy link
Copy Markdown

@abhinavgupta-hmrc abhinavgupta-hmrc marked this pull request as ready for review April 27, 2026 16:03
Comment thread app/controllers/verify/VerificationRequestSubmittedController.scala
abhinavgupta-hmrc and others added 21 commits April 29, 2026 11:06
…ror) (#156)

* DTR-4694: Screen SM-07 Verification failure (departmental error)

* DTR-4694: apply scalafmtAll

* DTR-4694: remove unuse GovukButton and back link
* DTR-4806 business function F4 - conditional routing

* DTR-4806 missing test cases added for None case
@jassalrichy
Copy link
Copy Markdown
Contributor

Within VerificationRequestSubmittedViewModel
Potentially there may be no subcontractor to verify:
subcontractorsToVerify: Seq[String] = Seq.empty

@jassalrichy
Copy link
Copy Markdown
Contributor

jassalrichy commented May 6, 2026

Within VerificationRequestSubmittedViewModel:
confirmationEmail assumes the user has decided to enter a difererent email from whats on record for this contractor.
We will need to check if EmailAddressPage will be used to store the on record email address, if the user decides not to override it.

@jassalrichy
Copy link
Copy Markdown
Contributor

Few observations on the page layout which does not match the prototype:

  1. Remove the Back link
  2. There should not be divider lines after 'Subcontractor to verify' and 'Subcontractors to reverify' sections.
  3. The (Reference Number 12345) should not be enclosed in brackets (need to check this with UCD team)
  4. Remove line spacing between 'Your verification reference number' and 'Reference Number 12345'
  5. Both lists of subcontractors should be displayed in alphabetical order
  6. Link 'verification history' is incorrect.
  7. Link 'Manage your subcontractors' needs to have the instanceId (cisId) appended:
    http://localhost:6996/construction-industry-scheme/management/manage-subcontractors/{cisId}
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants